Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medev: a CLI tool to work with mediator #865

Merged
merged 1 commit into from
Sep 6, 2023
Merged

medev: a CLI tool to work with mediator #865

merged 1 commit into from
Sep 6, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 6, 2023

The intention is to separate development (e.g. rule type development) tools from
the day-to-day CLI utilities. This makes the medic CLI slimmer and allows us to pack
more dependencies and functionality into the new medev command.

For now, this merely separates the code, subsequent PRs will deal with releasing a
binary.

The intention is to separate development (e.g. rule type development) tools from
the day-to-day CLI utilities. This makes the `medic` CLI slimmer and allows us to pack
more dependencies and functionality into the new `medev` command.

For now, this merely separates the code, subsequent PRs will deal with releasing a
binary.
@JAORMX JAORMX changed the title medev: a CLI tool to work with mediator medev: a CLI tool to work with mediator Sep 6, 2023
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge, I think the idea is good. Should we maybe add a makefile target for easier build?

On thing that would be super cool is to have a command that you would feed a JSON to and it would send a webhook with the right integrity checksum to mediator because it could read the shared secret from config.yaml...

@lukehinds
Copy link
Contributor

I like to hold on this until we have had some discussion, ideally this would be a epic.

I kind of like the idea of having a single binary, but understand bloat is a concern.

@JAORMX JAORMX merged commit 5469937 into main Sep 6, 2023
12 checks passed
@JAORMX JAORMX deleted the medev branch September 6, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants