reconcilers: Add an initial concept of a dedicated reconcilers object in mediator #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
changed the title
JAORMX
force-pushed
the
reconcilers-refactor
branch
4 times, most recently
from
0543a9d
to
b6e564c
Compare
JAORMX
changed the title
|
@jhrozek you mentioned you had some comments. |
… in mediator This creates a reconcilers object whose purpose is to persist the entities when needed and call for policy evaluation if required. The intent is to add further functionality here so we could do gradual or scheduled reconciles of objects.
This uses the passthrough builtin ingestor and a simple rego rule that always passes.
JAORMX
force-pushed
the
reconcilers-refactor
branch
from
3ece65e
to
ced60e3
Compare
jhrozek
approved these changes
Sep 7, 2023
| return nil, fmt.Errorf("error generating UUID: %w", err) | ||
| } | ||
|
|
||
| msg := message.NewMessage(id.String(), nil) |
There was a problem hiding this comment.
small nit: should we return nil, err rather than empty_msg, err on error? (I know that the caller should just not touch the first return parameter on error..)
| WithProvider(ectx.Provider). | ||
| WithGroupID(ectx.Group.ID). | ||
| WithRepository(repo). | ||
| WithRepositoryID(dbrepo.ID) |
There was a problem hiding this comment.
since all handlers are now building entityInfoWrapper, then calling buildMessage and then publish using the same topic for all the publishers now, maybe another refactor might be to have a closure that would just return the entityInfoWrapper and then a shared code would build the message and publish it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a reconcilers object whose purpose is to persist the entities when
needed and call for policy evaluation if required. The intent is to add
further functionality here so we could do gradual or scheduled reconciles of objects.
This also adds a unit test for the executor!