Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule_type create: Print one table instead of many #906

Merged
merged 1 commit into from
Sep 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/cli/app/rule_type/rule_type_create.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ within a mediator control plane.`,
return fmt.Errorf("error expanding file args: %w", err)
}

table := initializeTable(cmd)

for _, f := range expfiles {
preader, closer, err := util.OpenFileArg(f, cmd.InOrStdin())
if err != nil {
Expand All @@ -84,11 +86,11 @@ within a mediator control plane.`,
return fmt.Errorf("error creating rule type: %w", err)
}

table := initializeTable(cmd)
renderRuleTypeTable(resp.RuleType, table)
table.Render()
}

table.Render()

return nil
},
}
Expand Down