Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuthService endpoint that got fixed manually #909

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

evankanderson
Copy link
Member

@evankanderson evankanderson commented Sep 8, 2023

Found via:

helm upgrade --dry-run -n mediator mediator oci://ghcr.io/stacklok/mediator/helm/mediator --values values-extracted.yaml > /tmp/update-output
vi /tmp/update-output
kubectl diff -n mediator -f /tmp/update-output

Which had the expected changes:

  • migrateup job
  • dbname config changes
  • image URL changes

And this change, which seems to have been due to manual fixing after the helm install, and never made it back into the chart. mediator.proto confirms the OAuthService spelling.

@@ -43,7 +43,7 @@
             name: mediator-grpc
             port:
               name: grpc
-        path: /mediator.v1.OAuthService
+        path: /mediator.v1.OauthService
         pathType: Prefix
       - backend:
           service:

@evankanderson evankanderson merged commit 6d3c7bf into mindersec:main Sep 8, 2023
12 checks passed
@evankanderson
Copy link
Member Author

Woo! 1-bit PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants