Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: Don't process events from repositories that are not registered #928

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 11, 2023

This returns an error if the repository does not belong to a group. This way we won't
have funky issues when trying to evaluate a policy for a non-existent group.

This returns an error if the repository does not belong to a group. This way we won't
have funky issues when trying to evaluate a policy for a non-existent group.
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since even the built-in root group starts with 0

@JAORMX JAORMX merged commit fb7ffea into main Sep 11, 2023
12 checks passed
@JAORMX JAORMX deleted the webhook-repo branch September 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants