Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnerability evaluator: Submit reviews with just comment if the author is the same as the mediator identity #952

Merged
merged 1 commit into from
Sep 15, 2023
Merged

vulnerability evaluator: Submit reviews with just comment if the author is the same as the mediator identity #952

merged 1 commit into from
Sep 15, 2023

Commits on Sep 14, 2023

  1. vulnerability evaluator: Submit reviews with just comment if the auth… 

    …or is the same as the mediator identity

Because github doesn't let you review your own code, in case mediator is
running as the same identity as the contributor submitting the PR, we
can't request changes.

In that case, let's just mark the review as commenting instead of
changes requested. A follow-up patch would then set the commit status to
failed to prevent merge.

Fixes: #951
    @jhrozek
    jhrozek committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    bf7f727 View commit details
    Browse the repository at this point in the history