Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial introduction of providers to the database #955

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Add initial introduction of providers to the database #955

merged 12 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Add initial introduction of providers to the database 

    This simply replaces the usages of the `github` provider checks and instead
provides a simple implementation of providers that will be expanded upon.

The intent is to leave the same functionality as-is, but instead rely on a
provider that's installed on every organization by default.

I've left traces of how the implementation will evolve by adding a definition
and a `providers_type` column to the providers database. These will serve as the means
of instantiating providers dynamically, instead of always building the github one
as we do today. But, to keep things short, I've left that out of this PR.
    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2d170e2 View commit details
    Browse the repository at this point in the history

  2. Change logic of revoke tokens call to revoke everything

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a4d832a View commit details
    Browse the repository at this point in the history

  3. Remove hardcoded check for github in policy helper

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c6f8536 View commit details
    Browse the repository at this point in the history

  4. Decouple entities from groups 

    This removes the group information from entities in favor of
relying on providers for data integrity.
    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c2fe49f View commit details
    Browse the repository at this point in the history

  5. Revert "Decouple entities from groups" 

    This reverts commit 84ce748.
    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8becaa2 View commit details
    Browse the repository at this point in the history

  6. Use provider name + group ID as compount foreign key 

    Co-Authored-By: Evan Anderson <evan@stacklok.com>
    @JAORMX @evankanderson
    JAORMX and evankanderson committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d3f38d8 View commit details
    Browse the repository at this point in the history

  7. Remove UNIQUE constraints for providers and groups from entities 

    These prevent us from creating multiple objects which is not the desired outcome.
    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    745d412 View commit details
    Browse the repository at this point in the history

  8. Fix unit tests

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    352cccf View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary comment.

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c364e40 View commit details
    Browse the repository at this point in the history

  10. rename stuttering function name

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1c37ff3 View commit details
    Browse the repository at this point in the history

  11. reconcilers: Return error on transcient sql error

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    43ced75 View commit details
    Browse the repository at this point in the history

  12. don't pass group ID to get repositories call

    @JAORMX
    JAORMX committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a5a5476 View commit details
    Browse the repository at this point in the history