Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Manually update opentelemetry dependencies to fix go.mod #995

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 22, 2023

It appears that otel deprecated and moved packages in the 1.18 release
according to their
changelog
and OPA either didn't catch up or the go module dependency got otherwise
confused leading to issues like:

go: module go.opentelemetry.io/otel/exporters/otlp is deprecated: Use
exporters/otlp/otlptrace or exporters/otlp/otlpmetric instead.

and:

github.com/stacklok/mediator/internal/engine/eval/rego imports
        github.com/open-policy-agent/opa/rego imports
        github.com/open-policy-agent/opa/plugins tested by
        github.com/open-policy-agent/opa/plugins.test imports
        github.com/open-policy-agent/opa/internal/distributedtracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig: module go.opentelemetry.io/otel/exporters/otlp/otlptrace@latest found (v1.18.0), but does not contain package go.opentelemetry.io/otel/
exporters/otlp/otlptrace/internal/otlpconfig

It appears that manually go-getting otlptrace fixes the issue for me.

It appears that otel deprecated and moved packages in the 1.18 release
according to their
[changelog](https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.18.0)
and OPA either didn't catch up or the go module dependency got otherwise
confused leading to issues like:

```
go: module go.opentelemetry.io/otel/exporters/otlp is deprecated: Use
exporters/otlp/otlptrace or exporters/otlp/otlpmetric instead.
```

and:
```
github.com/stacklok/mediator/internal/engine/eval/rego imports
        github.com/open-policy-agent/opa/rego imports
        github.com/open-policy-agent/opa/plugins tested by
        github.com/open-policy-agent/opa/plugins.test imports
        github.com/open-policy-agent/opa/internal/distributedtracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig: module go.opentelemetry.io/otel/exporters/otlp/otlptrace@latest found (v1.18.0), but does not contain package go.opentelemetry.io/otel/
exporters/otlp/otlptrace/internal/otlpconfig
```

It appears that manually go-getting otlptrace fixes the issue for me.
@JAORMX JAORMX merged commit 93128d6 into mindersec:main Sep 22, 2023
12 checks passed
@JAORMX JAORMX deleted the tidy branch September 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants