Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording: allow for storing recorded responses in human-readable form #270

Closed
wants to merge 12 commits into from

Conversation

wojciak
Copy link

@wojciak wojciak commented Nov 25, 2024

  • This pull requests adds the option to disable hex-encoding of the recording in the response.
  • The reasoning for this feature is to be able to save the recordings in human-readable form
  • The human readable form of the recordings allows easy review of new mocks and hand-tuning them to cover a wider variaty of cases when used with interceptors such as pook

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@coveralls
Copy link

Coverage Status

coverage: 99.167% (-0.09%) from 99.255%
when pulling 366a5f2 on e-z-health:feature/use_hex_encoding
into 0da2722 on mindflayer:main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 99.167% (-0.09%) from 99.255%
when pulling 366a5f2 on e-z-health:feature/use_hex_encoding
into 0da2722 on mindflayer:main.

@coveralls
Copy link

Coverage Status

coverage: 99.167% (-0.09%) from 99.255%
when pulling 366a5f2 on e-z-health:feature/use_hex_encoding
into 0da2722 on mindflayer:main.

@mindflayer
Copy link
Owner

mindflayer commented Nov 25, 2024

I am sorry I cannot accept this PR the way it is done.
Mocket core is not bound to a specific protocol, while your code works with the assumption that what you want to dump is an HTTP call.

@wojciak
Copy link
Author

wojciak commented Nov 26, 2024

Closing in wait for #274

@wojciak wojciak closed this Nov 26, 2024
@mindflayer
Copy link
Owner

I've just released a beta version with the huge refactor allowing to set a different storage class: https://pypi.org/project/mocket/3.13.3b1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants