Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added power limit related methods #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added power limit related methods #6

wants to merge 4 commits into from

Conversation

aleksandrov
Copy link

  • PowerLimit()
  • PowerLimitConstraints()
  • SetPowerLimit()

rohitagarwal003
rohitagarwal003 requested changes May 14, 2018
View reviewed changes
Copy link
Member

@rohitagarwal003 rohitagarwal003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aleksandrov.

Sorry for the late review. Just got around to taking a look at this.

bindings.go
}

// Set new power limit of this device.
func (d Device) SetPowerLimit(pl uint) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this method? I would like to keep this library to only read things and not change anything.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mindprince Sorry for even late comments :-) Why you do not want to have altering state functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitagarwal003 rohitagarwal003 rohitagarwal003 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aleksandrov @rohitagarwal003