Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show e-mail checkbox is always enabled #441

Closed
navjottomer opened this issue Nov 18, 2021 · 2 comments
Closed

Show e-mail checkbox is always enabled #441

navjottomer opened this issue Nov 18, 2021 · 2 comments
Labels
fixed Fixed in develop or feature branch but not merged in main branch.

Comments

@navjottomer
Copy link
Member

In the new version of the site, the Show e-mail checkbox is always enabled, it cannot be turned off even by the administrator.

Originally posted by @buninsan in #435 (comment)
navjottomer added a commit that referenced this issue Nov 18, 2021
@navjottomer
Fix: #441 issue with checkbox input.
1f601e3
@eurobank
Copy link

@buninsan Does this fix work for you?

@patriksh
Copy link
Contributor

This fixed the "always enabled" but there's still problems with how value is read from session. For me it now always kept it unchecked.

if (Session::newInstance()->_getForm('showEmail') != 0) should probably be if (Session::newInstance()->_getForm('showEmail') != "") in show_email_checkbox.

navjottomer added a commit that referenced this issue Apr 3, 2023
@navjottomer
Fix #441 Show e-mail checkbox is always enabled
b9ede4c
@navjottomer navjottomer added the fixed Fixed in develop or feature branch but not merged in main branch. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Fixed in develop or feature branch but not merged in main branch.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@navjottomer @eurobank @patriksh