Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number CF #443

Merged
merged 7 commits into from
Nov 21, 2021
Merged

Add number CF #443

merged 7 commits into from
Nov 21, 2021

Conversation

patriksh
Copy link
Contributor

patriksh and others added 7 commits November 21, 2021 01:50
@patriksh
Add number CF
8f28f55
@code-factor
[CodeFactor] Apply fixes to commit 8f28f55
40c4a3e 
[ci skip] [skip ci]
@navjottomer
Update InputInterface.php
218613e 
We don't need a number type field, the default text field is enough.
@navjottomer
Update FormInputs.php
3f1abec 
Removing number type input, text input can be used instead.
@navjottomer
Update FieldForm.php
d070405 
number to text input type
@navjottomer
Update InputInterface.php
fb87f7b
@navjottomer
Update InputInterface.php
767a1fc 
line ending.
@navjottomer
Copy link
Member

Please check if it is still working after my changes.

@patriksh
Copy link
Contributor Author

Works fine.

@navjottomer
Copy link
Member

Great work.

@navjottomer navjottomer merged commit f662cb4 into mindstellar:develop Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patriksh @navjottomer @code-factor