Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainly importing log4j and lombok #240

Merged
merged 58 commits into from
Jan 14, 2024

Conversation

boholder
Copy link
Member

@boholder boholder commented Jan 14, 2024

Pull Request Checklist

- [ ] A new fragment is added in ./doc/news that describes what is new (refer to issue #174).

  • The unit test suite passes at the latest commit of this PR branch.

Describe what you have changed in this PR

Based on #238 , branching from #239, new commits from 2f1bb79 to 79695a3.
Have a tough time with custom log4j config for developing convenience, and succeeded thanks to kindly help.

 of getBlockAndFluidTargetInformation and getBlockAndFluidTargetPosition
maybe we can utilize it in the future, far future when developing new features
so we can use it to save accurate position (Vec3d) and use it as BlockPos type (extended from Vec 3i)
to fit logic of lockOnEntity method
…ak", let player chose whether to play drum sound or speak when unlocking
@boholder boholder added the 1.20 label Jan 14, 2024
@boholder boholder mentioned this pull request Jan 14, 2024
1 task
@khanshoaib3 khanshoaib3 merged commit abe461a into minecraft-access:1.20 Jan 14, 2024
1 check passed
@boholder boholder deleted the 1.20-log4j-again branch January 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants