Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bidirectional streaming using WebSockets #2

Merged
merged 14 commits into from
Mar 2, 2022
Merged

Support bidirectional streaming using WebSockets #2

merged 14 commits into from
Mar 2, 2022

Conversation

robinbraemer
Copy link
Member

@robinbraemer robinbraemer commented Feb 28, 2022 •
edited
Loading

This PR adds support for serving WatchService and TunnelService bidirectional stream over WebSockets, provides clients and more tests.

TODO

  • Use service and client options to hide the underlying network transport
    • Improves abstraction between gRPC and WebSocket
  • Write tests

@robinbraemer robinbraemer added the enhancement New feature or request label Feb 28, 2022
@robinbraemer robinbraemer mentioned this pull request Mar 1, 2022
Merged
@robinbraemer robinbraemer merged commit 0207f68 into main Mar 2, 2022
@robinbraemer robinbraemer deleted the ws branch March 2, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robinbraemer