Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiation values do not add #136

Closed
programmerjake opened this issue Mar 11, 2024 · 0 comments · Fixed by #139
Closed

radiation values do not add #136

programmerjake opened this issue Mar 11, 2024 · 0 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@programmerjake
Copy link

when using with armor from https://github.com/mt-mods/technic_armor, the putting different pieces of lead armor on in some cases make the radiation value decrease by putting on more armor instead of increasing as expected.

this looks to be caused by:

3d_armor/3d_armor/api.lua

Lines 416 to 419 in 7fc313f

-- DEPRECATED, use armor_groups instead
if def.groups["armor_radiation"] and levels["radiation"] then
levels["radiation"] = def.groups["armor_radiation"]
end

which incorrectly replaces the radiation value instead of adding.

@BuckarooBanzay BuckarooBanzay added the bug Something isn't working label Mar 11, 2024
mckaygerhard added a commit to minenux/minetest-mod-3d_armor that referenced this issue Mar 27, 2024
* Closes minetest-mods#136
  radiation does not work when using technic armor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants