Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init-cleanup #115

Merged
merged 1 commit into from
Oct 26, 2023
Merged

init-cleanup #115

merged 1 commit into from
Oct 26, 2023

Conversation

BuckarooBanzay
Copy link
Member

clean up some init-related functions

it's been 6 years since that (very questionable) part of the code was written and some engine-bugs that may have been circumvented by this should now be fixed anyway.

Needs additional testing, everything worked for me but who knows 🤷

CC @dacmot

Copy link

@Lazerbeak12345 Lazerbeak12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code review only I don't see any problems.

@dacmot
Copy link

dacmot commented Oct 23, 2023

The problem described in #114 is gone. I did some play testing too and couldn't find any issue.

Thanks!

Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BuckarooBanzay BuckarooBanzay merged commit 3660e50 into master Oct 26, 2023
@Niklp09 Niklp09 deleted the init-cleanup branch October 26, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants