Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MineClonia compat #677

Merged
merged 2 commits into from
Aug 16, 2024
Merged

MineClonia compat #677

merged 2 commits into from
Aug 16, 2024

Conversation

nonfreegithub
Copy link
Contributor

No description provided.

@SmallJoker
Copy link
Member

SmallJoker commented Aug 1, 2024 •
edited
Loading

LGTM. Will merge in a few days unless there are objections.

The linter disagrees. @nonfreegithub Would you please be so nice to add the missing global variables to the .luacheckrc file?

@nonfreegithub
Copy link
Contributor Author

globals added

@SmallJoker
Copy link
Member

Thanks. Will merge in a few days unless there are objections.

@sfan5 sfan5 merged commit 9ff3ab1 into minetest-mods:master Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nonfreegithub @SmallJoker @sfan5