Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from intllib to minetest translations and update Spanish #535

Closed
wants to merge 2 commits into from
Closed

Change from intllib to minetest translations and update Spanish #535

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2020

No description provided.

@louisroyer
Copy link
Contributor

louisroyer commented Mar 13, 2020

#529 also adds more translation strings related to chest:register and fixes some issues with wrought iron conversion. You may want to add your spanish translation improvement over this PR instead.

@ghost
Copy link
Author

ghost commented Mar 13, 2020

I didn't find #529 before, I don't know how to add it, because it lacks strings to translate, like the names of the digiline channels example: @ 1_battery_box technic/machines/register/battery_box.lua 318

@louisroyer
Copy link
Contributor

This string is used with

meta:set_string("channel", ltier.."_battery_box"..minetest.pos_to_string(pos))

channel is used by digiline and acts as an unique identifier. I may be wrong, but I think this string is never displayed and is used for internal purpose only. Even if it were printed, it may break things with digiline because users would not be able to write correctly this identifier in digiline code (using mesecon's luacontroller).

If they are any other string I forgot, please let me know.

@ghost
Copy link
Author

ghost commented Mar 13, 2020

That string is displayed when the drum channel is edited, the player can change it at any time.
Screenshot_20200313_142307
Switching station also has a switching_station.lua 46

@louisroyer
Copy link
Contributor

This means if you translate this string, its actual (=internal) initial value will be @technic)lv_battery_box(-32,3,65). If the player do not edit this, and try to create a program in luacontroller using the displayed identifier caja_de_bateria_bv(-32,3,65), the program will not work until the channel is edited. Translating the default channel name without breaking this require server side translation, but minetest translation api provide client side translation.
The case of switching station is similar to this one.

@ghost
Copy link
Author

ghost commented Mar 13, 2020

you're right, it should be blank as the force field because it can't be translated and there are players who think they are untouchable values

@ghost ghost closed this Mar 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant