Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change node color for OCI #120

Closed
mumanoha opened this issue May 5, 2020 · 15 comments · Fixed by #121 or #205
Closed

How to change node color for OCI #120

mumanoha opened this issue May 5, 2020 · 15 comments · Fixed by #121 or #205
Assignees
Labels
area/provider/oci OCI provider comp/node Issue of node component kind/feat/icon Icon request

Comments

@mumanoha
Copy link

mumanoha commented May 5, 2020

First of all, Thanks a lot for this amazing innovative tool!! Great work!!

I am new to this tool and still learning it, so please forgive me if I am wrong.

Based on my research, there is no way to change the color of the node / cloud resources icon, lets say for OCI, it's always black, but Oracle is Red. Is that something that you guys can provide a resolution?

Thanks in advance for the help / support!!

@mingrammer
Copy link
Owner

Hi. Thanks for your compliments.

First, there is no way to change the node color because all node is based on icon images. So node color depends on the color of icon image. And the OCI icons are grey colored.

But we can add the red-colored images so that able to use red node. Fortunately, there are red-colored icon image set: https://docs.cloud.oracle.com/en-us/iaas/Content/General/Reference/graphicsfordiagrams.htm

@mingrammer mingrammer added kind/feat/icon Icon request comp/node Issue of node component labels May 5, 2020
@mingrammer
Copy link
Owner

mingrammer commented May 5, 2020

I'll add red-colored node support.

@mingrammer
Copy link
Owner

Red-colored OCI nodes will be added to next version.

@mumanoha
Copy link
Author

mumanoha commented May 5, 2020 via email

@mingrammer
Copy link
Owner

Screenshot you attachted is not available to me. Could you please attach that in GitHub comment?

@mumanoha
Copy link
Author

mumanoha commented May 5, 2020

Red-colored OCI nodes will be added to next version.

when this will be available? And how to use it? Please let me know.

@mingrammer
Copy link
Owner

Maybe tomorrow, I can release next version.

And there is no way to change the cluster background color yet. I should also work for it.

@mumanoha
Copy link
Author

mumanoha commented May 6, 2020

Maybe tomorrow, I can release next version.

And there is no way to change the cluster background color yet. I should also work for it.

Can you please let me know whether the new version is ready? If yes, how to use it?

@mingrammer
Copy link
Owner

mingrammer commented May 6, 2020

It's working hours now. Please wait until May 06 at 21:00 KST at least.

It will be released before May 07 00:00:00 KST.

@mingrammer
Copy link
Owner

mingrammer commented May 6, 2020

@mumanoha Diagrams v0.10.0 is now released.

You can use both red and grey colored nodes for OCI provider: https://diagrams.mingrammer.com/docs/nodes/oci. Default is red colored.

@lucianf
Copy link
Contributor

lucianf commented Jun 18, 2020

Just noticed this.

@mingrammer back in February I made a pull request (#46) that you accepted. This introduced the then-current OCI icon set, which came in two colours, "bark" (a sort of dark brown) and white, which conformed to the new Oracle branding. Now you've reverted to the red/white icon set - but this is an outdated one. @mumanoha Oracle doesn't use red for OCI icons anymore.

I'm going to submit a new pull request with the latest icon set, again in bark and white (a slight variation of the February set). Please stick to this going forward - this is the current Oracle branding which is to be used in all OCI diagrams.

@mingrammer
Copy link
Owner

mingrammer commented Jun 18, 2020

@lucianf Hi! :)

I didn't know that the bark and white tones are the new branding icon set. Sorry for that :(. Yes, it would be good to revert it and keep the icon colors with the official new Oracle branding. @mumanoha Check it, please :)

@mingrammer mingrammer reopened this Jun 18, 2020
@lucianf
Copy link
Contributor

lucianf commented Jun 18, 2020

PR #205. I've also added a few new services. The icons are 256x256 scaled up from the official SVGs.

@mumanoha
Copy link
Author

Just noticed this.

@mingrammer back in February I made a pull request (#46) that you accepted. This introduced the then-current OCI icon set, which came in two colours, "bark" (a sort of dark brown) and white, which conformed to the new Oracle branding. Now you've reverted to the red/white icon set - but this is an outdated one. @mumanoha Oracle doesn't use red for OCI icons anymore.

I'm going to submit a new pull request with the latest icon set, again in bark and white (a slight variation of the February set). Please stick to this going forward - this is the current Oracle branding which is to be used in all OCI diagrams.

@lucianf I am with Oracle and I agree that we changed our branding color, but the red icons are still been used by many architecture diagrams both internally & externally. Is it possible to keep red icons and also bark & white icons to give that flexibility for end user to pick what color they prefer instead of removing the red color?

@lucianf
Copy link
Contributor

lucianf commented Jun 18, 2020

@mumanoha sorry I don't agree - the branding has changed and going forward all Oracle materials is to be designed with the Redwood corporate theme. The OCI old red/white icon set may be common, but it is now very much obsolete.

@mingrammer mingrammer linked a pull request Jul 3, 2020 that will close this issue
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/oci OCI provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
3 participants