Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slack #89

Closed
yu-iskw opened this issue Apr 1, 2020 · 11 comments
Closed

Add slack #89

yu-iskw opened this issue Apr 1, 2020 · 11 comments
Labels
kind/feat/provider Provider request proposal Suggestion proposed status/accepted Accepted proposal

Comments

@yu-iskw
Copy link
Contributor

yu-iskw commented Apr 1, 2020

Motivation

We sometimes do chatops with slack. We can potentially regard slack as a part of cloud architecture. So, it would be great to add the slack icon.

Resources

https://brandfolder.com/slack/logos

Comment

If it would be ok to add slack, I am not sure where it should be categorized.
@mingrammer mingrammer added kind/feature New feature or request kind/feat/icon Icon request labels Apr 6, 2020
@mingrammer
Copy link
Owner

I agree with you. And we can use the Slack as notification component as well.

@mingrammer
Copy link
Owner

I'm thinking about which category is appropriate for Slack .. 🤔 Any ideas?

@taylorreece
Copy link
Contributor

Would it make sense to have a diagrams.onprem.social category, and throw in Slack, IRC, Microsoft Teams, Skype, Facebook, Twitter, etc?

@mingrammer
Copy link
Owner

social is not bad. I like it. How about it? @yu-iskw

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Apr 18, 2020

social is not bad to me too. Personally, I prefer communication, but it is a little long as a namespace.

Another discussion is whether or not we can use diagrams.onprem, because we cannot use slack on onpremis environmenst at the moment.

@mingrammer
Copy link
Owner

mingrammer commented Apr 18, 2020 •
edited
Loading

Ye we should discuss about that. I think the Slack, MS teams, Twitter and others mentioned above might not be fit to diagrams.onprem provider. So I propose a new provider, the saas. Then we can categorize them in more detail like this:

  • diagrams.saas.social.Facebook
  • diagrams.saas.social.Twitter
  • diagrams.saas.messenger.Slack (or chat.Slack)
  • diagrams.saas.messenger.Telegram (or chat.Telegram)
    ...

Any thoughts?

@mingrammer mingrammer added the proposal Suggestion proposed label Apr 18, 2020
@taylorreece
Copy link
Contributor

Ye we should discuss about that. I think the Slack, MS teams, Twitter and others mentioned above might not be fit to diagrams.onprem provider. So I propose a new provider, the saas. Then we can categorize them in more detail like this:

  • diagrams.saas.social.Facebook
  • diagrams.saas.social.Twitter
  • diagrams.saas.messenger.Slack (or chat.Slack)
  • diagrams.saas.messenger.Telegram (or chat.Telegram)
    ...

Any thoughts?

I really like that proposal

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Apr 23, 2020

@mingrammer I love your proposal.

@mingrammer mingrammer added kind/feat/provider Provider request and removed kind/feat/icon Icon request kind/feature New feature or request labels Apr 23, 2020
@mingrammer mingrammer mentioned this issue May 15, 2020
Closed
@dhirschfeld
Copy link

I'll put in a plug for zulip; though happy to try adding it myself if there's a good location to put it.

@mingrammer mingrammer added the status/accepted Accepted proposal label May 21, 2020
@mingrammer mingrammer pinned this issue May 21, 2020
@mingrammer mingrammer linked a pull request May 25, 2020 that will close this issue
Add Saas (#89) #168
Closed
@mingrammer
Copy link
Owner

@gabriel-tessier is working on it.

mingrammer pushed a commit that referenced this issue May 26, 2020
@gabriel-tessier
Add Saas v2 (#89) (#173)
eddeb38
@mingrammer
Copy link
Owner

It will be added in the next version.

@mingrammer mingrammer unpinned this issue Jun 2, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this issue Jun 4, 2020
@nlamirault
Merge branch 'master' into feature/elasticstack
bc3d020 
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
nlamirault added a commit to nlamirault/diagrams that referenced this issue Jun 4, 2020
@nlamirault
Merge branch 'master' into feature/tekton
4557141 
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feat/provider Provider request proposal Suggestion proposed status/accepted Accepted proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Saas (#89)
4 participants
@dhirschfeld @yu-iskw @taylorreece @mingrammer