Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sonarqube logo #1032

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

filipeaaoliveira
Copy link
Collaborator

This merge requests adds the logo for Sonarqube.

I've added it into SaaS alerting.

See if this makes sense for you guys to have it here as we don't have anything like Sonarqube right now, but it's not just for alerting.

@filipeaaoliveira filipeaaoliveira linked an issue Oct 18, 2024 that may be closed by this pull request
@gabriel-tessier
Copy link
Collaborator

@filipeaaoliveira

I did not know about Sonar, but reading the wikipedia page it's more like a security tool for me.
In onprem we have trivy which is similar tool for container and it's under security.
https://diagrams.mingrammer.com/docs/nodes/onprem#onpremsecurity

For me it make more sense to put it under SaaS security.

@filipeaaoliveira filipeaaoliveira self-assigned this Oct 20, 2024
@filipeaaoliveira
Copy link
Collaborator Author

I think that makes sense, I just didn't know if you guys wanted to create a new folder.

I'll update it.
Thanks!

@filipeaaoliveira filipeaaoliveira merged commit a5a3ef7 into master Nov 2, 2024
5 checks passed
@filipeaaoliveira filipeaaoliveira deleted the 1031-feature-request-add-sonarqube-logo branch November 2, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/saas SaaS provider kind/feat/icon Icon request status/need-to-review Need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add SonarQube Logo
2 participants