fix: Convert UPPER_WORDS from string to tuple type #1092 #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-tessier
approved these changes
Feb 2, 2025
gabriel-tessier
requested review from
mingrammer,
tvqphuoc01 and
filipeaaoliveira
|
@tiaz0128 Thank you for the PR, this one is smaller so it can be merged more quickly, I just wait for another maintainer to approve before. |
tvqphuoc01
approved these changes
Feb 4, 2025
|
Thank you. This is my first open-source contribution in my life. I really appreciate your help that allowed me to contribute to a library I love. I plan to continue contributing by adding more providers to the diagrams project in the future. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1092
In config.py, some provider configurations are using string type while others are using tuple type. This inconsistency could lead to potential bugs and should be standardized across all providers.