Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify package/include instead of auto-discovery #1100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

specify package/include instead of auto-discovery #1100

wants to merge 1 commit into from

Conversation

sarnold
Copy link

@sarnold sarnold commented Jan 26, 2025

Fixes several failure modes related to broken installs and missing icons as documented in issue #1099

@sarnold
fix: dev: use the correct packaging bits instead of auto-discovery
0c64398 
Signed-off-by: Stephen L Arnold <sarnold@vctlabs.com>
@gabriel-tessier
Copy link
Collaborator

@sarnold
Thank you for the PR, and the time you spend digging this problem.
We have a lot of issue open about this problem, I hope it can solve it.
We will try to review you PR quickly before the end of his month 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-tessier gabriel-tessier Awaiting requested review from gabriel-tessier

@mingrammer mingrammer Awaiting requested review from mingrammer

@tvqphuoc01 tvqphuoc01 Awaiting requested review from tvqphuoc01

@filipeaaoliveira filipeaaoliveira Awaiting requested review from filipeaaoliveira

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarnold @gabriel-tessier