Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line support using scripts/generate.py #132

Closed
wants to merge 1 commit into from
Closed

Add command line support using scripts/generate.py #132

wants to merge 1 commit into from

Conversation

OverkillGuy
Copy link

Ship a poetry script (package-exported executable command) from the
scripts/generate.py file.

Refactor the main into a function for entrypoint purposes.

Ref #131

Ship a poetry script (package-exported executable command) from the
scripts/generate.py file.

Refactor the main into a function for entrypoint purposes
@OverkillGuy
Copy link
Author

Note that I do not know how the generate.py script is supposed to work, I just repackaged it to binary for now. I can only execute that generate function from diagrams command right now, but didn't yet run it successfully.

Marked PR as draft until that's understood.

@OverkillGuy
Copy link
Author

Hmm on second thought, my drive-by contribution might be ill conceived, my apologies.
I thought the generate.py file was meant as a CLI shortcut to render images, seems it's not meant for that at all.

I still believe exposing a binary command is valuable in general, and the side effect of allowing pipx installation without a python project sounds great too?

@mingrammer
Copy link
Owner

Ye, the generate.py is not for generating the diagrams. It is used for generating the node classes for the diagrams library.

I saw the issue you created: #131. I'll review that feature positively :)

Thank you!

@mingrammer mingrammer closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants