Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sagemaker resources #204

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Adding sagemaker resources #204

merged 1 commit into from
Jun 17, 2020

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Jun 17, 2020 •
edited
Loading

image

@leandrodamascena
Copy link
Contributor Author

Hi @mingrammer . Are you ok?! If you have a free time, could you update pip package?

Our project depends on diagram to draw resources (https://github.com/Cloud-Architects/cloudiscovery).

Thank you.

mingrammer
mingrammer approved these changes Jun 17, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer mingrammer merged commit c0bb034 into mingrammer:master Jun 17, 2020
@mingrammer
Copy link
Owner

Your project, cloudiscovery looks awesome. Great :)

I'll release the next version soon.

@mingrammer
Copy link
Owner

mingrammer commented Jun 17, 2020 •
edited
Loading

@leandrodamascena Can I add the cloudiscovery in the Who use it list?

@leandrodamascena
Copy link
Contributor Author

@mingrammer of course you can!! :D

And thanks for you feedback .. We thank you about diagrams project, it's an important resource in our project!

@mingrammer
Copy link
Owner

Thank you :) And the Diagrams v0.14.0 is now released! Please try with this version.

@leandrodamascena
Copy link
Contributor Author

Nice.. I'll update diagrams version and try!! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrodamascena @mingrammer