Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for PersistentVolume #207

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

denverdino
Copy link
Contributor

The PersistentVolume in diagrams/k8s/storage.py is incorrect!

@mingrammer
Copy link
Owner

mingrammer commented Jun 22, 2020

Thank you for reporting it. Could you please follow the contribution guides? You shouldn't edit the node class files by yourself, you can fix the icon image name, and should run the autogen.sh to update it.

@mingrammer mingrammer added area/provider/k8s Kubernetes provider comp/node Issue of node component labels Jun 22, 2020
@denverdino
Copy link
Contributor Author

@mingrammer updated with autogen.sh

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mingrammer mingrammer merged commit 61e36a4 into mingrammer:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/k8s Kubernetes provider comp/node Issue of node component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants