Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Auth0, Cloudflare, Recombee Nodes #209

Merged
merged 2 commits into from
Jun 24, 2020
Merged

New Auth0, Cloudflare, Recombee Nodes #209

merged 2 commits into from
Jun 24, 2020

Conversation

hagaishapira
Copy link
Contributor

All placed in saas under identity, cdn, and recommendation respectively.

mingrammer
mingrammer reviewed Jun 24, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo only icons would be better I think. Could you please update the icons? (and you should fit the image size to a maximum of 256 pixels wide or high.)

@mingrammer mingrammer added the comp/node Issue of node component label Jun 24, 2020
mingrammer
mingrammer reviewed Jun 24, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the security category for the auth0?

@hagaishapira
Copy link
Contributor Author

What do you think about the security category for the auth0?

I think security is another category which should hold actual security services, for network, cloud, endpoints and what not...
Auth0, like its competitors Okta, AWS cognito..., are identity management/providers which of course has to do with security but are not active security products.

@mingrammer
Copy link
Owner

Sounds reasonable to me. Thanks for your explanation!

mingrammer
mingrammer approved these changes Jun 24, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingrammer mingrammer merged commit 4c377a0 into mingrammer:master Jun 24, 2020
@hagaishapira hagaishapira mentioned this pull request Jun 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
comp/node Issue of node component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagaishapira @mingrammer