feat(docker): Add support for CJK fonts + Replace ms-fonts with opens… #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ans.
There's 2 changes in one push:
1- Added support for CJK fonts as with the actual version the CJK was displayed as square (see the second screenshot).
2- Replaced ms-font with opensans as opensans fonts are already in the official repository and for sure will have better support.
As you can see in the diagrams generated the text is sometimes going outside of the bound with ms-fonts, the version with opensans is more clean.
With opensans
With ms-font
