Add Outscale Provider #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingrammer
reviewed
Aug 19, 2020
| @@ -108,6 +108,9 @@ def cleaner_saas(f): | |||
| def cleaner_elastic(f): | |||
| return f.lower() | |||
|
|
|||
| def cleaner_outscale(f): | |||
There was a problem hiding this comment.
Please keep 2 lines of space between functions.
There was a problem hiding this comment.
That should be done,
Thanks for the review
config.py
Outdated
| @@ -66,6 +67,8 @@ | |||
| "oci": ("oci", "ocid", "oke", "ocir", "ddos", "waf", "bm", "vm", "cdn", "vpn", "dns", "nat", "dms", "api", "id"), | |||
| "elastic": ("apm", "siem", "ece", "eck"), | |||
| "generic": ("vpn", "ios", "xen", "sql"), | |||
| "outscale": ("osc",), | |||
| "generic": ("vpn", "ios", "xen"), | |||
There was a problem hiding this comment.
generic key is duplicated, remove it plz.
autogen.sh
Outdated
| @@ -31,25 +31,25 @@ for pvd in "${providers[@]}"; do | |||
| # convert the svg to png for azure provider | |||
| if [ "$pvd" = "onprem" ] || [ "$pvd" = "azure" ]; then | |||
| echo "converting the svg to png using inkscape for provider '$pvd'" | |||
| python -m scripts.resource svg2png "$pvd" | |||
| python3 -m scripts.resource svg2png "$pvd" | |||
There was a problem hiding this comment.
Diagrams uses Python3 as the default interpreter, Python3 is standard, and Python2 is deprecated. So, since we can assume that python is for version 3, it doesn't seem necessary to specify python3 I think.
Also, diagrams is using poetry as a package manager and virtual environment manager. We have already specified to use Python3 as default version: https://github.com/mingrammer/diagrams/blob/master/pyproject.toml#L13
mingrammer
added
kind/feat/provider
Outscale isa French IaaS provider This commit add support for generated diagram with outscale images Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Outscale is a French IaaS provider.
This Pull Request add support for Outscale Provider.
Thanks,
Matthias Gatto