Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DigitalOcean provider #621

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Added DigitalOcean provider #621

merged 3 commits into from
Jan 22, 2022

Conversation

mandalae
Copy link
Contributor

I've added assets and a provider for DigitalOcean.

I tried to follow the development and contribution guides, but if I've done anything wrong, please let me know.

@mandalae
Copy link
Contributor Author

@mingrammer Is there any way to get this reviewed? I notice that there are quite a lot of PRs outstanding, so I'm wondering if this is still actively being worked on?

mingrammer
mingrammer requested changes Jan 21, 2022
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz check the azure config.

config.py Outdated Show resolved Hide resolved
@mingrammer
Copy link
Owner

Sorry for the late reply. @mandalae

@mandalae
Copy link
Contributor Author

Thanks for reviewing, I've fixed that comment now :)

@mingrammer
Copy link
Owner

@mandalae Please re-run the autogen script!

@mandalae
Copy link
Contributor Author

@mingrammer Done, a lot of the changes in this PR came from doing that in the first place I think. I only really added the DO stuff, I never meant to change anything in AWS or Azure.

mingrammer
mingrammer approved these changes Jan 22, 2022
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Thank you for working on it.

@mingrammer mingrammer merged commit 98ec2af into mingrammer:master Jan 22, 2022
mingrammer pushed a commit that referenced this pull request Jan 22, 2022
@mandalae @mingrammer
feat(provider): added DigitalOcean provider (#621)
51e7303 
* Added DigitalOcean provider

* Fix PR comment

* Reran the autogen script

Co-authored-by: Chris Skaaning <cskaaning@digitalocean.com>
@mingrammer
Copy link
Owner

v0.21.0 is now released.

@dajor
Copy link

dajor commented Feb 5, 2022 •
edited
Loading

Is in the last version not a init.py missing for DigitalOcean?

digitalocean/network.py", line 3, in
from . import _DigitalOcean
ImportError: cannot import name '_DigitalOcean' from 'diagrams.digitalocean' (unknown location)

@mandalae
Copy link
Contributor Author

mandalae commented Feb 6, 2022

Correct @dajor I've added it in this PR: #646 :) - Thanks for pointing it out.

@dajor
Copy link

dajor commented Feb 6, 2022

There is one more bug:

from diagrams import Diagram

from diagrams.digitalocean.network import LoadBalancer
from diagrams.digitalocean.storage import Space

from diagrams.digitalocean.compute import Containers

with Diagram("Test", show=False):
LoadBalancer >> Containers >> Space

Traceback (most recent call last):
Containers >> Space
TypeError: unsupported operand type(s) for >>: 'type' and 'type'

haad added a commit to haad/diagrams that referenced this pull request May 12, 2022
@haad
Merge branch 'mhmdio/master' into terraform-provider
d89326a 
* mhmdio/master:
  bump: up to version 0.21.1
  feat(output): Generate dot file and support multi outformat.(mingrammer#441) Re (mingrammer#592)
  feat: add digitalocean provider (mingrammer#646)
  docs(website): update docs
  bump: up to version 0.21.0
  docs(readme): update badges
  docs(readme): update
  docs(readme): add digital ocean badge
  feat(provider): added DigitalOcean provider (mingrammer#621)
  feat(node): Dremio Service in OnPrem.Analytics (mingrammer#451)
  chore(deps): bump shelljs from 0.8.4 to 0.8.5 in /website (mingrammer#641)
  feat(node): add Nagios in OnPrem monitoring (mingrammer#638)
  feat(node): adding GCP API gateway image (mingrammer#636)
  feat(node): add chatbot icon (mingrammer#633)
  chore(deps): bump graphviz from 0.17 to 0.19.1 (mingrammer#635)
  feat(node): added Dapr programming runtime (mingrammer#591)
  docs: add mac dev guide (mingrammer#576)
  docs(readme): add Python 3.9 to badges (mingrammer#584)
  👌 IMPROVE: HashiCorp Icons
  📦 NEW: Add remaining HashiCorp Icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandalae @mingrammer @dajor