Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated + Added extra Elastic icons #742

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Updated + Added extra Elastic icons #742

merged 6 commits into from
Nov 9, 2022

Conversation

jamesagarside
Copy link
Contributor

@jamesagarside jamesagarside commented Aug 16, 2022 •
edited
Loading

Add and Update Elastic icons: Delivers issue: #756

@jamesagarside jamesagarside reopened this Aug 16, 2022
@jamesagarside
Copy link
Contributor Author

@mingrammer brilliant project, thank you for getting this going!
What is your approval process for pull requests, keen to get this merged so I can start using the additions in my designs :)

@jamesagarside
Copy link
Contributor Author

@mingrammer any luck on this getting merged please?

I work at Elastic and use this project for some designs

@jamesagarside jamesagarside mentioned this pull request Sep 6, 2022
Closed
mingrammer
mingrammer approved these changes Nov 8, 2022
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@mingrammer
Copy link
Owner

@jamesagarside Sorry for the late review. Great improvments. Please resolve the conflicts.

@mingrammer
Copy link
Owner

mingrammer commented Nov 8, 2022 •
edited
Loading

Closes #756.

@jamesagarside
Copy link
Contributor Author

@mingrammer resolved :D New Docs build had been added

@mingrammer
Copy link
Owner

There are too many file changes. @jamesagarside Could you please fix it or re-open the PR? 🙏

@mingrammer
Copy link
Owner

mingrammer commented Nov 8, 2022 •
edited
Loading

I'll update the master with the latest autogenerated files. Wait a minute, please.

@mingrammer
Copy link
Owner

@jamesagarside I fixed some resource gen issues. Please merge the master and re-run the autogen script.

@mingrammer
Copy link
Owner

Or you can just delete the website/static/img/resources/resources directory.

@jamesagarside
Copy link
Contributor Author

@mingrammer directory removed. Apologies

@jamesagarside
Copy link
Contributor Author

Ignore me, made a mistake

@jamesagarside
Copy link
Contributor Author

@mingrammer Fixed :D

mingrammer
mingrammer approved these changes Nov 9, 2022
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@mingrammer mingrammer merged commit e3e6d80 into mingrammer:master Nov 9, 2022
@jamesagarside jamesagarside deleted the elastic-update branch November 20, 2022 10:54
ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this pull request Nov 25, 2022
@jamesagarside @ngruelaneo
feat(node): Updated + Added extra Elastic icons (mingrammer#742)
89bd3aa 
* Updated + Added extra Elastic icons

* Updated from Master

* Removed website images

* Revert "Removed website images"

This reverts commit ac7cb2d.

* Removed resources/resources
@gabriel-tessier gabriel-tessier mentioned this pull request Dec 3, 2022
Merged
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this pull request Nov 8, 2023
@jamesagarside @ajmaradiaga
feat(node): Updated + Added extra Elastic icons (mingrammer#742)
67b9979 
* Updated + Added extra Elastic icons

* Updated from Master

* Removed website images

* Revert "Removed website images"

This reverts commit ac7cb2d.

* Removed resources/resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesagarside @mingrammer