Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EMQX as an On-Prem Queue entry #769

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Conversation

Nosferatu31
Copy link
Contributor

No description provided.

@Nosferatu31
Copy link
Contributor Author

@mingrammer I hope I did follow the community guidelines :)

@Nosferatu31 Nosferatu31 changed the title Add EMQX as a On-Prem Queue entry Add EMQX as an On-Prem Queue entry Nov 2, 2022
@mingrammer
Copy link
Owner

The icon looks too small. (120x120) Could you please replace it with 256x256 size?

@mingrammer
Copy link
Owner

And resolve the conflict please.

@Nosferatu31
Copy link
Contributor Author

@mingrammer about the icon size: that was the largest I could find from EMQ. I will check with them again.

@Nosferatu31
Copy link
Contributor Author

@mingrammer done.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer
Copy link
Owner

Thank you :D

@mingrammer mingrammer merged commit d764026 into mingrammer:master Nov 8, 2022
@Nosferatu31
Copy link
Contributor Author

Thank you :D

you're welcome 💪

ngruelaneo pushed a commit to aneoconsulting/diagrams that referenced this pull request Nov 25, 2022
* Add EMQX as a On-Prem Queue entry

* Add larger EMQX icon
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this pull request Nov 8, 2023
* Add EMQX as a On-Prem Queue entry

* Add larger EMQX icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants