Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add phoenix framework #975

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

ogabriel
Copy link
Contributor

@ogabriel ogabriel commented Feb 23, 2024

Just adds the phoenix framework image

Reference of the framework: https://www.phoenixframework.org/

@ogabriel ogabriel marked this pull request as ready for review February 23, 2024 13:48
@ogabriel
Copy link
Contributor Author

hi @gabriel-tessier, any possibility for you to also review this? Simple framework logo addition. Thanks in advance.

@gabriel-tessier
Copy link
Collaborator

@ogabriel
Thanks for the PR,
I already approved but just ask another peer, for double check.

Copy link
Collaborator

@tvqphuoc01 tvqphuoc01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabriel-tessier gabriel-tessier merged commit 1c380b0 into mingrammer:master Nov 20, 2024
7 checks passed
@ogabriel ogabriel deleted the add-phoenix-framework branch November 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants