Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter type of outformat #985

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix parameter type of outformat #985

merged 1 commit into from
Oct 28, 2024

Conversation

liancheng
Copy link
Contributor

According to the implementation of Diagram.__init__, outformat can be either a str or a list[str], but the function parameter type only accepts str. This PR fixes this issue.

@gabriel-tessier
Copy link
Collaborator

@liancheng
Good catch thank for the PR.

@filipeaaoliveira filipeaaoliveira merged commit b67e056 into mingrammer:master Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvqphuoc01 tvqphuoc01 tvqphuoc01 approved these changes

@gabriel-tessier gabriel-tessier gabriel-tessier approved these changes

@filipeaaoliveira filipeaaoliveira Awaiting requested review from filipeaaoliveira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liancheng @gabriel-tessier @tvqphuoc01 @filipeaaoliveira