fix: NA in the middle of the layout #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #211 +/- ##
==========================================
+ Coverage 88.18% 88.20% +0.02%
==========================================
Files 14 14
Lines 1718 1713 -5
==========================================
- Hits 1515 1511 -4
+ Misses 203 202 -1 ☔ View full report in Codecov by Sentry. |
Fersoil
deleted the
210-fix-dilutions-are-not-recognised-if-the-layout-files-has-holes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #210, the plate reader fails in case there are some holes in the middle of the layout file. Due to the parsing method, some samples were not correctly read in such plate files.
This PR fixes this issue by modifying the setters functions of the
plate_builderclass. The modifications include proper selection of the layout elements based on the locations obtained from the plate CSV file.I also added simple tests with plate and layout files.