Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

489 fix calc chain.xml #491

Merged
merged 3 commits into from
May 9, 2023

Conversation

jsgervais
Copy link
Contributor

@jsgervais jsgervais commented May 8, 2023

This change recreates file /xl/calcChain.xml in the archive to fix this error when loading an exel template file that has cells with functions that changed location (i.e. pushed down after adding rows from enumerable

image

Also removed unused parameter xmlWriterSettings in GenerateSheetXmlImpl, and some autoformatting (whitespaces)

Jean-Sebastien Gervais added 2 commits May 8, 2023 18:36
@shps951023 shps951023 merged commit 7a19581 into mini-software:master May 9, 2023
@fhucko
Copy link

fhucko commented Jun 28, 2023

This change (probably) added the message in Excel "we found problem" in my file. I tried version 1.30.3 and it works without the error.
Here is my file
Sales_journal_CZ_2305_CZ.xlsx
I used SaveAsByTemplateAsync, test data can be empty object.

@MatiasSchwinch
Copy link

Same error, i have a document with multiple sheets and it only runs when I pull out the formulas.

@jsgervais
Copy link
Contributor Author

jsgervais commented Jan 11, 2024 via email

@MatiasSchwinch
Copy link

Hello Matias, I've just seen the error. Can you provide samples of the template that doesnt run with formulas? I can use some simple formulas and conditional formatting in excel, I'm thinking that you have a different use case than simple repeated rows or single cells replacement. I remember i had issue with formulas containing a variable in brackets (function with templates var) Get Outlook for Androidhttps://aka.ms/AAb9ysg

________________________________ From: Matias @.> Sent: Thursday, January 11, 2024 6:50:47 AM To: mini-software/MiniExcel @.> Cc: Jean-Sébastien Gervais @.>; Author @.> Subject: Re: [mini-software/MiniExcel] 489 fix calc chain.xml (PR #491) Same error, i have a document with multiple sheets and it only runs when I pull out the formulas. — Reply to this email directly, view it on GitHub<#491 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABZEGP2DIEKMEQRACYWOG3LYN4LMNAVCNFSM6AAAAAAX253LFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVHA3TANZVGE. You are receiving this because you authored the thread.Message ID: @.***>

Hello Jean-Sébastien,

I hope this well, I leave attached below 2 templates that a colleague created, where this error occurs, along with the final file already built by MiniExcel, maybe they are helpful:

Template:
template.xlsx

Final File:
test.xlsx

Greetings, and good start of the year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants