Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip null values when writing to Excel #497

Merged
merged 3 commits into from
May 28, 2023
Merged

Add option to skip null values when writing to Excel #497

merged 3 commits into from
May 28, 2023

Conversation

0MG-DEN
Copy link
Contributor

@0MG-DEN 0MG-DEN commented May 17, 2023 •
edited
Loading

Fixes #496
new

jsgervais
jsgervais approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jsgervais jsgervais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Should document the new configuration option

@0MG-DEN 0MG-DEN requested a review from jsgervais May 27, 2023 18:26
@shps951023 shps951023 merged commit 42eab33 into mini-software:master May 28, 2023
@shps951023
Copy link
Member

@0MG-DEN merged 👍👍👍

@0MG-DEN 0MG-DEN deleted the fix496 branch May 28, 2023 11:42
@0MG-DEN
Copy link
Contributor Author

0MG-DEN commented May 28, 2023 •
edited
Loading

Thanks for the invite @shps951023
Unfortunately I have a lot currently going on and won't be able keep committing/providing any help/support on regular basis hence I'd rather keep occasionally committing when I have something to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shps951023 shps951023 shps951023 approved these changes

@jsgervais jsgervais Awaiting requested review from jsgervais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't write empty cells for null values
3 participants
@0MG-DEN @shps951023 @jsgervais