Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]对于是否可下载的url判定有问题 #27

Closed
magic-akari opened this issue Feb 26, 2018 · 2 comments · Fixed by #28
Closed

[BUG]对于是否可下载的url判定有问题 #27

magic-akari opened this issue Feb 26, 2018 · 2 comments · Fixed by #28

Comments

@magic-akari
Copy link
Contributor

直接判断url会有是否符合 filetype 会有 corner case.
我遇到的情况是，跳转 https://lrc-maker.github.io/?audioSrc=http%3A%2F%2Fexample.com%2Fexample.mp3 会意外触发下载。

应该对 url 进行解析，忽略 searchParms ,只处理 pathname.
@magic-akari magic-akari mentioned this issue Feb 26, 2018
Merged
miniers added a commit that referenced this issue Feb 26, 2018
@miniers
Merge pull request #28 from hufan-akari/patch-1
79b37c0 
fix #27
miniers added a commit that referenced this issue Feb 26, 2018
@miniers
build for fix #27
b73f810
@magic-akari
Copy link
Contributor Author

endsWith 写成了endswith, 真是抱歉哈。

@miniers
Copy link
Owner

miniers commented Feb 26, 2018

😂发烧了也没注意看😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #27
2 participants
@miniers @magic-akari