Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a home-made implementation of Titelize #3027

Closed
wants to merge 1 commit into from

Conversation

jvoisin
Copy link
Collaborator

@jvoisin jvoisin commented Dec 21, 2024

The implementation is equivalent to
cases.Title(language.English).String(strings.ToLower(…)), and this is the only place in miniflux where
"golang.org/x/text/cases" and "golang.org/x/text/language" are (directly) used.

This reduces the binary size from 27015590 to
26686112 on my machine.

Kudos to https://gsa.zxilly.dev for making it straightforward to catch things like this.

The implementation is equivalent to
`cases.Title(language.English).String(strings.ToLower(…))`,
and this is the only place in miniflux where
"golang.org/x/text/cases" and "golang.org/x/text/language"
are (directly) used.

This reduces the binary size from 27015590 to
26686112 on my machine.

Kudos to https://gsa.zxilly.dev for making it straightforward to catch things
like this.
@jvoisin jvoisin marked this pull request as draft December 21, 2024 01:01
@jvoisin jvoisin closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant