Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4 prediction different than previous release (under certain test case) #92

Closed
channelz opened this issue Feb 23, 2021 · 1 comment

Comments

@channelz
Copy link

channelz commented Feb 23, 2021

Test case 1:
Prompt : <soq> What is
Prediction : soq> What is .....

^the leading '<' is always trimmed away. Did not preform this way in the previous release.

Test case 2:
Prompt : What is
Prediction : What is ...

The prediction is as expected.

@minimaxir
Copy link
Owner

minimaxir commented Feb 23, 2021

In 0.4.0 I added an lstrip param (default true) to strip whitespace from the beginning of the text: however, it appears ^\W+ is the wrong regex since it'll catch the leading <.

You can set lstrip=False to generate() for the time being but I'll add a more correct regex.

minimaxir added a commit that referenced this issue Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants