More dependency detection fixes with DNF5 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DNF5 does not state "Dependencies resolved", which prevented the dependency resolver from ever moving to state==3. Instead, it states "Repositories loaded". * DNF5 states "Package ... is already installed" after "Repositories loaded" and before "Installing:", while state==2. * DNF5 includes "Installing: ## packages" in its Transaction Summary, which needs to be ignored so as to not move to state==3.
|
Here's at least a way to run the function by itself so you can test it manually: https://github.com/minimization/content-resolver/blob/master/test_root_log_function.py |
|
Thanks, running that on a sample dnf5-driven root.log returns the expected results with my commit:
and without my commit, only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR is not handling any dependencies from builds since the switch to dnf5, which is messing up the package count. This comes from a close analysis of the differences between root.log files generated by both dnf-4 and dnf5, but I'm not sure how to test this.
Once merged, any cached root.log containing
dnf5should be removed from the cache so as to force re-analysis of such builds.