Fix content type issue #3424
Merged
Fix content type issue #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application returns index.html, it should always use Content-Type: text/html to ensure that the returned HTML is rendered. It previously used the MIME-type that was derived from the extension, which may cause erratic behaviour for some extensions.
Although http.ServeContent detects the content automatically, based on the extension we do need to set Content-Type: text/html explicitly. The http.FileServer is kind of crap, because you can't provide special handling for the (pretty common) scenario that the file can't be found. This is solved by intercepting some calls (via the notFoundRedirectRespWr type), but this doesn't prevent that the response headers are already prepared. That's why we need to set the content-type back to HTML again.
I also changed the logic, so the SPA file-server application is generated only once.
IMPORTANT: This issue doesn't occur when running via yarn start. Run make build-static to update the local front-end, rebuild and start the back-end and connect via http://localhost:8444/ to reproduce the issue.