-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid ListBuckets to keep Stat() ops on bucket simpler #2699
Conversation
581d74c
to
ab48077
Compare
Codecov Report
@@ Coverage Diff @@
## master #2699 +/- ##
=========================================
- Coverage 9.69% 9.66% -0.03%
=========================================
Files 128 128
Lines 12109 12093 -16
=========================================
- Hits 1174 1169 -5
+ Misses 10785 10772 -13
- Partials 150 152 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2699 +/- ##
=========================================
- Coverage 9.69% 9.54% -0.15%
=========================================
Files 128 126 -2
Lines 12109 12055 -54
=========================================
- Hits 1174 1151 -23
+ Misses 10785 10760 -25
+ Partials 150 144 -6
Continue to review full report at Codecov.
|
ab48077
to
561afdb
Compare
Due to multi-user feature on Minio and mc adoption in many different restrictive environments, most users disable access to ListBuckets() calls. We can avoid such network operations as they only add marginal value.
561afdb
to
c3c0e57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a getonly policy for multi-user, without ListBuckets access, works well. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the following policy that works on a bucket named bucket
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"s3:GetBucketLocation",
"s3:GetObject",
"s3:ListBucket"
],
"Resource": [
"arn:aws:s3:::bucket/*"
]
}
]
}
Failed with buckets not named bucket
as expected.
Due to multi-user feature on Minio and
mc
adoption inmany different restrictive environments, most users disable
access to ListBuckets() calls. We can avoid such network
operations as they only add marginal value.