-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IAMAWSProviderExample work again #1037
Conversation
Please run |
I did, but I get a lot of lint errors on the project, except the IAMAWSProviderExample.cs (I would guess it has something to do with the tabs/indent; I just removed them to see if it helps). Would you mind giving me a hint what could be wrong with the file formatting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not sure what lint errors you've seen but the format-check test is happy and passed. |
@ebozduman maybe it has something to do with Rider and it uses Rider's cleanup logic? regitlint output looks like this:
I tried to fix some of those suggestions but getting more afterwards and cancelled that process. Also there might be later use of some parameters/variables that are currently not in use and get suggested to cleanup. |
It could be, but your commit helped. |
fixes example code for #1036