Fixes strong name signature failure for MinIO 4.0.3 NuGet pkg #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
There were 2 package references to the
Newtonsoft.Json" Version="13.0.1"in our dotnet code base, 1- for MinIO project, and 2nd for Functional tests project.When an MVC Web Application template is created in Visual Studio, a version conflict happens since Web Application depends on an older version of the same package,
Newtonsoft.Json" Version="12.0.2". This can happen and it is expected. So, Visual Studio detects it and shows a message about it during MinIO 4.0.3 installation when dependencies are listed and the required package reference changes are done only for MinIO package and not for the internal project. That was causing the strong name signature verification failure.The fix is simply removing the extraneous package reference from the internal project.