Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 2 more bucket notification functional tests #668

Merged
merged 6 commits into from
Sep 3, 2022
Merged

Adds 2 more bucket notification functional tests #668

merged 6 commits into from
Sep 3, 2022

Conversation

ebozduman
Copy link
Collaborator

Adding 2 more bucket notification tests to cover the testing scenarios that cause the problems explained in issue #649.

@ebozduman ebozduman force-pushed the bucket-notification-new-tests branch from 6d7eb31 to 17fd7a1 Compare July 27, 2022 08:01
@ebozduman
Copy link
Collaborator Author

@harshavardhana
Is there anything we are waiting for this PR?

@ebozduman
Copy link
Collaborator Author

ebozduman commented Aug 16, 2022 •
edited
Loading

Just checked. My master and my branch are both up to date.
We just need 1 approving review.
I checked one more time. Branch is not up to date and git fetch origin and git rebase origin/master runs without making any changes.
Looking into it.
@harshavardhana
I guess it was all about your last merge was missing in my local branch.
So, we just need 1 approving review.

@harshavardhana harshavardhana merged commit 0403260 into minio:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas Awaiting requested review from poornas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebozduman @harshavardhana