Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue 673 #677

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Fixing issue 673 #677

merged 3 commits into from
Aug 31, 2022

Conversation

anthonyMc11
Copy link
Contributor

When the listObjects is called the region was not being calculated ( because the objectName is null) .
This caused a error on s3 to use the perminently redirected address instead of getting the files, now the region is calculated correctly, the code works as expected

@anthonyMc11
Fixing issue 673
4f7f151 
When the listObjects is called the region was not being calculated ( because the objectName is null) .
This caused a error on s3 to use the perminently redirected address instead of getting the files, now the region is calculated correctly, the code works as expected
ebozduman
ebozduman approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman
Copy link
Collaborator

ebozduman commented Aug 16, 2022 •
edited
Loading

@anthonyMc11
Please fix the build issues.

About build issue on Linux:
Please run dotnet regitlint and push the lint changes into your PR.

About build failure on Windows:

error: Minio.Exceptions.UnexpectedMinioException: MinIO\
API responded with message=Storage backend has reached its minimum
free drive threshold. Please delete a few objects to proceed.

This could be a false alert/glitch. The docker image used in this test is Windows base OS container, hence we should not have a storage space problem there.
Let's see how the build tests run after pushing the regitlint change.

@anthonyMc11
Copy link
Contributor Author

@ebozduman I have completed the lint command and updated my PR with the result of it

@anthonyMc11
Copy link
Contributor Author

merged in master

@ebozduman ebozduman merged commit 26d43d4 into minio:master Aug 31, 2022
@ebozduman ebozduman mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyMc11 @ebozduman