-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes WithProxy(#658) and HttpClient(#675) issues #683
Conversation
@Ruthlessist Thank your for your contribution effort. |
…lse to indicate whether to dispose httpClient.
@ebozduman Respecting the decision of the design team, although I don't think Dependency Injection and Builder patterns are opposites, the modification regarding constructors is now removed. |
@Ruthlessist There are build failures that need to be fixed. The Linux build failure is because of the lint check.
You can either run |
@Ruthlessist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As soon as the lint changes are in we can merge.
Fixes 2 issues:
HttpClient
when delayed untilBuild()
.HttpClient
cannot change theProxy
, add a hint for the ignoredWithProxy(IWebProxy)
.HttpClient
is the basic dependency ofMinioClient
,MinioClient (HttpClient)
is still necessary to implement dependency injection.HttpClient
is managed by IoC or other implementations, and there may even be other operations externally, so add an identifier to control theDispose()
behavior.