Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #766

Merged
merged 14 commits into from
Apr 17, 2023
Merged

Fix warnings #766

merged 14 commits into from
Apr 17, 2023

Conversation

martijn00
Copy link
Contributor

No description provided.

@martijn00
Copy link
Contributor Author

@ebozduman can you run the CI?

@martijn00
Copy link
Contributor Author

@ebozduman not sure why linux fails... can you try run that one again?

@ebozduman
Copy link
Collaborator

Yes, I see the same failure for the other PR (#731) and trying again

@martijn00
Copy link
Contributor Author

@ebozduman it seems to work now!

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 91dc25e into minio:master Apr 17, 2023
Urantij pushed a commit to Urantij/minio-dotnet that referenced this pull request Apr 19, 2023
* Fix warnings

* More fixes

* More warnings

* And more

* More

* More

* Fixes

* Dispose correctly

* Add metadata

* Use uppercase

* No dispose

* Revert

* Headers type

* Don't cancel cancelled task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants