Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat replace dynamic with class #823

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

martijn00
Copy link
Contributor

Updated version of #795

@ebozduman can you run this?

@martijn00 martijn00 force-pushed the feat-replace-dynamic-with-class branch from a4b39c3 to b085d63 Compare August 3, 2023 15:22
ebozduman
ebozduman previously approved these changes Aug 4, 2023
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijn00 martijn00 force-pushed the feat-replace-dynamic-with-class branch from e86a879 to 074a0f4 Compare August 4, 2023 08:32
@martijn00
Copy link
Contributor Author

martijn00 commented Aug 4, 2023

@ebozduman Ive done a rebase to fix the conflict. Can you run again?

@martijn00
Copy link
Contributor Author

@ebozduman now it should be correct. Can you run again?

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman ebozduman merged commit 3762343 into minio:master Aug 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants